chore: fix peer ex tests #1869
Merged
chore: fix peer ex tests #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…eer-ex-flaky-tests
adklempner
approved these changes
Feb 29, 2024
weboko
reviewed
Feb 29, 2024
| peerId: nwaku3PeerId, | ||
| numPeers: numPeersToRequest | ||
| })) as PeerInfo[]; | ||
| peerInfos = await Promise.race([ |
There was a problem hiding this comment.
nit: worth making as util in @waku/tests - timeout(promise, seconds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PeerExchange query is slow and flaky in the CI (can't reproduce it locally)
I can decrease flakiness by increasing the timeouts to more than a minute but I still see each test failing and being retried a few times until it passes. For 4 tests this can add up to 7 minutes of execution time to the CI and it's just not worth it. So I've just left the most important test and skipped the negative ones for now. If we run on better CI machines in the future or the bootstrap speed improves (I think it's related to this), we can unskip them.