New relay keep alive feature #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for introducing a relay keep alive feature.
D4nte
force-pushed
the
185-idle-stream-abort
branch
from
0e6cd59
to
1ad60fa
Compare
..on `Waku` with a default to 5min to send ping messages over relay to ensure the relay stream stays open. This is a workaround until [js-libp2p#744](libp2p/js-libp2p#744) is done as there are issues when TCP(?) timeouts and the stream gets closed.
D4nte
force-pushed
the
185-idle-stream-abort
branch
from
1ad60fa
to
9638f6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new
relayKeepAliveoption onWakuwith a default to 59s to send ping messages over relay to ensure the relay stream stays open.This is a workaround until js-libp2p#744 is done as there are issues when TCP(?) timeouts and the stream gets closed
(#185, js-libp2p#939)