rest relay: avoid publish messages without timestamp information

waku-org · Nov 30, 2023 · 8968ee8 · 8968ee8
1 parent 72a1f8c
commit 8968ee8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/waku/waku_api/rest/relay/handlers.nim b/waku/waku_api/rest/relay/handlers.nim
@@ -125,7 +125,7 @@ proc installRelayApiHandlers*(router: var RestRouter, node: WakuNode, cache: Mes
       return error
 
     var message: WakuMessage = reqWakuMessage.toWakuMessage(version = 0).valueOr:
-      return RestApiResponse.badRequest()
+      return RestApiResponse.badRequest($error)
 
     # if RLN is mounted, append the proof to the message
     if not node.wakuRlnRelay.isNil():

diff --git a/waku/waku_api/rest/relay/types.nim b/waku/waku_api/rest/relay/types.nim
@@ -45,7 +45,10 @@ proc toWakuMessage*(msg: RelayWakuMessage, version = 0): Result[WakuMessage, str
     version = uint32(msg.version.get(version))
     timestamp = msg.timestamp.get(0)
 
-  ok(WakuMessage(payload: payload, contentTopic: contentTopic, version: version, timestamp: timestamp))
+  if timestamp == 0:
+    return err("timestamp cannot be 0 or empty")
+
+  return ok(WakuMessage(payload: payload, contentTopic: contentTopic, version: version, timestamp: timestamp))
 
 
 #### Serialization and deserialization