chore: discv5 re-org clean-up #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
force-pushed
the
chore-discv5-clean
branch
from
5efb056
to
09f9231
Compare
- Fix ENR creation - Fix wakubridge
SionoiS
force-pushed
the
chore-discv5-clean
branch
from
09f9231
to
1d07e3e
Compare
Ivansete-status
approved these changes
Jun 28, 2023
| udpPort = some(nodeUdpPort), | ||
| ) | ||
| builder.withWakuCapabilities(flags) | ||
| #builder.withMultiaddrs(???) |
There was a problem hiding this comment.
Not a big deal but I'd delete this comment
Comment on lines
296
to
297
| if not discv5BootstrapEnrsRes.isOk(): | ||
| error("failed discovering peers from DNS") |
There was a problem hiding this comment.
Suggested change
| if not discv5BootstrapEnrsRes.isOk(): | |
| error("failed discovering peers from DNS") | |
| if discv5BootstrapEnrsRes.isErr(): | |
| error("failed discovering peers from DNS: " & discv5BootstrapEnrsRes.error) |
| @@ -366,12 +405,12 @@ when isMainModule: | |||
| let restClient = clientRest.get() | |||
|
|
|||
| # start waku node | |||
| let nodeRes = initAndStartNode(conf) | |||
| let nodeRes = initAndStartApp(conf) | |||
There was a problem hiding this comment.
if we change this we'd need to change the previous comment and the next error message
There was a problem hiding this comment.
That's exactly the kind of errors I wish the tooling would catch... :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean-up remnants of the discv5 re-org
Changes
Tracking #1812