-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: discv5 re-org clean-up #1823
Conversation
5efb056
to
09f9231
Compare
- Fix ENR creation - Fix wakubridge
09f9231
to
1d07e3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great! Thanks for it!
I added a few minor comments
udpPort = some(nodeUdpPort), | ||
) | ||
builder.withWakuCapabilities(flags) | ||
#builder.withMultiaddrs(???) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal but I'd delete this comment
if not discv5BootstrapEnrsRes.isOk(): | ||
error("failed discovering peers from DNS") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not discv5BootstrapEnrsRes.isOk(): | |
error("failed discovering peers from DNS") | |
if discv5BootstrapEnrsRes.isErr(): | |
error("failed discovering peers from DNS: " & discv5BootstrapEnrsRes.error) |
@@ -366,12 +405,12 @@ when isMainModule: | |||
let restClient = clientRest.get() | |||
|
|||
# start waku node | |||
let nodeRes = initAndStartNode(conf) | |||
let nodeRes = initAndStartApp(conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we change this we'd need to change the previous comment and the next error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly the kind of errors I wish the tooling would catch... :(
Description
Clean-up remnants of the discv5 re-org
Changes
Tracking #1812