Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): remove registration capabilities #1887

Closed
2 tasks done
rymnc opened this issue Aug 7, 2023 · 3 comments · Fixed by #1916
Closed
2 tasks done

chore(rln-relay): remove registration capabilities #1887

rymnc opened this issue Aug 7, 2023 · 3 comments · Fixed by #1916
Assignees
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@rymnc
Copy link
Contributor

rymnc commented Aug 7, 2023

Background

Currently, rln-relay has 2 functions -

  1. Perform rate limiting on rln-relay protected topics
  2. Allow a user to register into the membership set

Details

As discussed in the offsite with @alrevuelta, it does not make sense to retain the "registration" capabilities in the rln-relay module, rather, we would expect users to obtain their membership out of band, via the application-specific registration criteria.

We should just accept keystore OR cli args with their membership details, and not provide registrations to our users.

Acceptance criteria

  • Remove registration from the OnChainGroupManager
  • Remove the private key cli arg to wakunode2/chat2

Need thumbs from @jm-clius here!

@jm-clius
Copy link
Contributor

jm-clius commented Aug 7, 2023

👍 for general direction, but wouldn't this be good to keep as a (perhaps hidden) dev feature?

@vpavlin
Copy link
Member

vpavlin commented Aug 7, 2023

I'd agree, maybe remove from CLI, keep in code?

@vpavlin vpavlin added E:2023-rln track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Aug 8, 2023
@rymnc
Copy link
Contributor Author

rymnc commented Aug 10, 2023

Not sure if we want to keep it altogether, if we're trying to cut scope as much as possible.
The current requirement for waku-rln-relay is that we permission a set of users into the membership set.
cc: @alrevuelta

@rymnc rymnc self-assigned this Aug 22, 2023
@fryorcraken fryorcraken added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants