feat: rln subcommands #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (60)
|
|
@alrevuelta The PR as it is right now can be used to create keystores. If you want, i can add some flag that could let you send the transactions and create the keystore items regardless of the transaction being mined or not. The subcommand also has some flags to specify the nonce, and gas price in case you need to modify this for your tests |
richard-ramos
force-pushed
the
rln-subcommand
branch
5 times, most recently
from
bdc1e63
to
420891c
Compare
richard-ramos
force-pushed
the
rln-subcommand
branch
2 times, most recently
from
6ce04a1
to
996c8a5
Compare
richard-ramos
force-pushed
the
rln-subcommand
branch
from
f4e7e04
to
a70ef8e
Compare
This was referenced Aug 22, 2023
rymnc
reviewed
Aug 22, 2023
| @@ -0,0 +1,3 @@ | |||
| [submodule "waku/v2/protocol/rln/contracts/rln-contract"] | |||
| path = waku/v2/protocol/rln/contracts/rln-contract | |||
| url = [email protected]:vacp2p/rln-contract.git | |||
There was a problem hiding this comment.
err we should use the waku-org/waku-rln-contract now!
There was a problem hiding this comment.
Using waku-rln-contract WakuRlnRegistry introduces a lot of breaking changes, due to how the bindings for go are modified and I end up not being able to retrieve the events:
waku/v2/protocol/rln/group_manager/dynamic/web3.go:17:73: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/web3.go:110:102: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/web3.go:111:27: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/web3.go:172:104: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/web3.go:173:37: gm.rlnContract.FilterMemberRegistered undefined (type *contracts.RLN has no field or method FilterMemberRegistered)
waku/v2/protocol/rln/group_manager/dynamic/dynamic.go:58:59: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/dynamic.go:73:36: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/dynamic.go:76:42: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/dynamic.go:151:24: gm.rlnContract.MEMBERSHIPDEPOSIT undefined (type *contracts.RLN has no field or method MEMBERSHIPDEPOSIT)
waku/v2/protocol/rln/group_manager/dynamic/dynamic.go:231:38: undefined: contracts.RLNMemberRegistered
waku/v2/protocol/rln/group_manager/dynamic/web3.go:173:37: too many errorsNotice how I can't easily filter events, nor obtain the fee.
Since @alrevuelta is still using vacp2p/rln-contract, I'll figure out how to solve the errors introduced by changing the contract in a separate PR.
chaitanyaprem
approved these changes
Aug 24, 2023
| cli "github.com/urfave/cli/v2" | ||
| ) | ||
|
|
||
| // Command generates a key file used to generate the node's peerID, encrypted with an optional password |
There was a problem hiding this comment.
Node's peerId maynot be tied to RLN membership right.
A user has the flexibility to use different public/private key pair for RLN and peerID generation.
There was a problem hiding this comment.
Correct. the peerID is not associated to rln. User is able to choose which credential to use via the membership group and keystore index flags
cmd/waku/rlngenerate/web3.go
Outdated
| return 0, fmt.Errorf("transaction error: %w", err) | ||
| } | ||
|
|
||
| url := "" |
There was a problem hiding this comment.
Better to rename to explorerURL
richard-ramos
force-pushed
the
rln-subcommand
branch
from
a70ef8e
to
060bcbc
Compare
richard-ramos
force-pushed
the
rln-subcommand
branch
from
060bcbc
to
93398ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See waku-org/nwaku#1887 for justification to remove registration from the wakunode.
Changes
Testing