Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-relay): readPersistentRlnCredentials returns a result #1310

Closed
wants to merge 2 commits into from
Closed

fix(rln-relay): readPersistentRlnCredentials returns a result #1310

wants to merge 2 commits into from

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Oct 28, 2022

Closes #1053, part of the effort to convert all errors thrown in the waku-rln-relay
protocol to results, and eventually enums
(#1245).

readPersistentRlnCredentials could raise OSErrors, IOErrors and Exceptions, and now
returns an RlnRelayResult.

@rymnc rymnc added this to the Release 0.13.0 milestone Oct 28, 2022
@rymnc rymnc added track:maintenance track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Oct 28, 2022
@rymnc rymnc self-assigned this Oct 28, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 28, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 011ee59 #1 2022-10-28 07:15:17 ~15 min linux 📦bin
✔️ 011ee59 #1 2022-10-28 07:17:55 ~17 min macos 📦bin

@s1fr0
Copy link
Contributor

s1fr0 commented Oct 28, 2022

This PR shows the importance of reviewing and merging fast PRs: this has been already addressed in #1285, specifically 6aa7805

@rymnc
Copy link
Contributor Author

rymnc commented Oct 28, 2022

Addressed in #1285

@rymnc rymnc closed this Oct 28, 2022
@rymnc rymnc deleted the fix-membership-error branch October 28, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius Awaiting requested review from jm-clius

@LNSD LNSD Awaiting requested review from LNSD

@s1fr0 s1fr0 Awaiting requested review from s1fr0

@staheri14 staheri14 Awaiting requested review from staheri14

Assignees

@rymnc rymnc

Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstraction of writing persistent RLN credentials to a modular proc
3 participants
@rymnc @status-im-auto @s1fr0