refactor(archive): sqlite query optimization. replace or-ed equal conditions list with in-list

[LNSD]

A small optimization for the "find messages by" query.

Source: https://stackoverflow.com/a/3074846/1099999

The OR operator needs a much more complex evaluation process than the IN construct because it allows many conditions, not only equals like IN.

Source: https://stackoverflow.com/a/73079261/1099999

IN may be significantly faster. E.g. table with ~23M rows.
OR -> Execution Time: 4540.829 ms
IN -> Execution Time: 855.743 ms

With 20 million message archive sizes, I think this query optimization will have a significant impact helping us to squeeze the Sqlite lemon a little bit more 🍋

[jm-clius]

Oh! Great!

[rymnc]

LGTM! great find. Not sure if sqlite will convert the in query to an or query under the hood.

[LNSD]

All CI test failures are unrelated to the PR changes. All Waku archive tests are passing. Ubuntu CI jobs are passing.

I have re-run the jobs, but the tests keep failing. cc #1357