fix: improve filter test race condition #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrevuelta
approved these changes
Feb 2, 2023
Very first run was cancelled as I pushed a new version. But this version did! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1357
Currently the most common cause for test failures in the
CIpipeline, seems to be related to filter tests.This is caused by a race condition between a subscribing client and a publishing filter service node. In each case I looked at, the race condition was a matter of ~100ms or less, so extra time padding should improve this.
Longer term this race condition should be avoided by using the improved filter specification and waiting for the subscribe transaction to be complete.
NB: I think .editorconfig changed quite a lot on this one! Please ignore whitespace to see the diff.