Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused imports #1553

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: remove unused imports #1553

merged 1 commit into from
Feb 13, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Feb 13, 2023

Another 🪴 PR. Removed the unused import warnings (except the chronicles one).

@LNSD LNSD self-assigned this Feb 13, 2023
@LNSD LNSD mentioned this pull request Feb 13, 2023
Merged
3 tasks
@LNSD
Copy link
Contributor Author

LNSD commented Feb 13, 2023

It seems that some peer_manager test cases are failing intermittently: https://github.com/waku-org/nwaku/actions/runs/4163008348/jobs/7202871447#step:5:5917

cc #1357

@alrevuelta
Copy link
Contributor

It seems that some peer_manager test cases are failing intermittently: https://github.com/waku-org/nwaku/actions/runs/4163008348/jobs/7202871447#step:5:5917

mm will check. seems to be the prunePeerStore test.

alrevuelta
alrevuelta approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

double checked that tests can be executed individually, since sometimes the unused warning lies a bit (like the one you mention chronicles). but all good :)

@LNSD LNSD merged commit 9a40ad6 into master Feb 13, 2023
@LNSD LNSD deleted the fix-unused-imports branch February 13, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrevuelta alrevuelta alrevuelta approved these changes

@rymnc rymnc Awaiting requested review from rymnc

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees

@LNSD LNSD

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LNSD @alrevuelta