Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(message): added waku message deterministic hashing #1586

Merged
merged 1 commit into from
Mar 2, 2023
Merged

feat(message): added waku message deterministic hashing #1586

merged 1 commit into from
Mar 2, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Mar 1, 2023

This PR adds support to calculate a Waku messages' hash following the 14/WAKU2-MESSAGE RFC:

  • Added the Waku message's digest submodule.
  • Defined test vectors and added test coverage for two scenarios: meta attribute present and not present.

@LNSD LNSD self-assigned this Mar 1, 2023
@LNSD LNSD mentioned this pull request Mar 1, 2023
Merged
@rymnc
Copy link
Contributor

rymnc commented Mar 2, 2023

ccing @richard-ramos and @fryorcraken for go and js implementation reference :)

rymnc
rymnc approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jm-clius
jm-clius approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LNSD LNSD merged commit a57bea2 into master Mar 2, 2023
@LNSD LNSD deleted the feat-message-digest branch March 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@rymnc rymnc rymnc approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees

@LNSD LNSD

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LNSD @rymnc @jm-clius