chore(rln-relay): move rln-relay test suite to own dir #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
commented
Mar 2, 2023
| @@ -48,7 +48,6 @@ import | |||
| ./v2/test_utils_peers, | |||
| ./v2/test_message_cache, | |||
| ./v2/test_peer_manager, | |||
| ./v2/test_web3, # TODO remove it when rln-relay tests get finalized | |||
There was a problem hiding this comment.
This is why the test_web3.nim file was removed
LNSD
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Thank you for this PR. I appreciate this 😄
LGTM ✅
I have one minor observation regarding the test_utils.nim file. I would keep the test_*.nim naming schema only for files that contain test cases. This makes it easier to navigate through the different test suites.
IMO, this shared test utility code file can be renamed to tests/v2/waku_rln_relay/utils.nim. Wdyt?
|
Addressed in 7af540a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @LNSD, this dir structure makes more sense for the waku_rln_relay test suite