chore: add peer manager config to builder #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrevuelta
force-pushed
the
add-maxrelay-builder
branch
from
02ef8ae
to
afa504c
Compare
Ivansete-status
approved these changes
Jun 22, 2023
alrevuelta
force-pushed
the
add-maxrelay-builder
branch
from
afa504c
to
62079d2
Compare
alrevuelta
force-pushed
the
add-maxrelay-builder
branch
from
5bf8765
to
74c288d
Compare
alrevuelta
force-pushed
the
add-maxrelay-builder
branch
from
74c288d
to
baeba34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withPeerManager()in the builder was not implemented nor used. This PR moves the switch creation fromwaku_nodeto thebuilderand simplifiesWakuNode.new()having less parameters.withPeerMangercan't be used since to build the PeerManager, we need the Switch, since its built inside.max-relay-peersto be used in future PRs.maxConnectionsis configured <50, but this is not the case in the fleets.