feat: ENR can now be updated

[SionoiS]

Description

I added a way to update the Discv5 ENR and used a AsyncEventQueue to broadcast topic subscriptions.

Changes

• Discv5 add/remove shard from ENR
• event system for topic subscriptions

Fix #1843

Followed by #1918

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1875

[jm-clius]

Approving to not be a bottleneck, but I'm not sure I agree with passing in discv5 into the API. The API should have no knowledge about discovery in general. Wouldn't it be possible (and simpler) to just have a "watcher" task on wakunode2/app.nim that monitors the subscribed topics on the node and triggers the discv5 ENR update when it notices a new/removed topic?

[SionoiS]

Approving to not be a bottleneck, but I'm not sure I agree with passing in discv5 into the API. The API should have no knowledge about discovery in general. Wouldn't it be possible (and simpler) to just have a "watcher" task on wakunode2/app.nim that monitors the subscribed topics on the node and triggers the discv5 ENR update when it notices a new/removed topic?

Yes it is a weird thing to do. I don't like your watcher idea either. Why watch for changes when the info could be sent directly.

I'll try to find something better. I wish I was more knowledgeable about NIm :(

[SionoiS]

I discussed with @richard-ramos go-waku way of sending the info. from the relay api to various waku sub-systems and it seams like more or less like I would have done it in Rust.

I still don't know what to do in Nim thought...

[SionoiS]

OK!

I'm now satisfied with this solution and we can expand upon it later too.

[Ivansete-status]

Is this PR duplicated? I feel like a dejavu :)
( #1918 )

[SionoiS]

Is this PR duplicated? I feel like a dejavu :) ( #1918 )

Yeah sorry should not have ask to review the follow-up PR before merging this.

[github-actions]

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.