Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat2): no enr record in chat2 #1907

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix(chat2): no enr record in chat2 #1907

merged 1 commit into from
Aug 15, 2023

Conversation

richard-ramos
Copy link
Member

Description

Fixes an node record is required error which crashes chat2.

Changes

  • build enr record and provide it to waku node

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1907

vpavlin
vpavlin approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richard-ramos richard-ramos merged commit fc604ca into master Aug 15, 2023
11 of 12 checks passed
@richard-ramos richard-ramos deleted the fix/enr branch August 15, 2023 00:43
rymnc pushed a commit that referenced this pull request Aug 16, 2023
@richard-ramos @rymnc
fix: no enr record in chat2 (#1907)
48a0828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavlin vpavlin vpavlin approved these changes

@SionoiS SionoiS Awaiting requested review from SionoiS

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-ramos @vpavlin