Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add debug log indicating succesful message pushes and also log the message hash #1965

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

richard-ramos
Copy link
Member

Description

one suggestion that was made during today's message reliability call was to add this information to help debug cases where a message appears to have been pushed succesfully to all subscribers yet the message appears to not have been delivered.

To see this change in action, it would require the fleet to be deployed and also use debug level for logs

Notice that might add some noise on the logs for full filter nodes, due to changing the log level for one of the messages from TRACE to DEBUG, and also due to adding an extra log line, but it should be an acceptable tradeoff while dogfooding for filter is in progress. We can do a separate PR in the future to change the affected log lines to TRACE

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1965

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will indeed lead to high log rates when there are many filter clients. Perhaps we can open an issue to revert log level to trace in future?

@Ivansete-status
Copy link
Collaborator

Thanks! This will indeed lead to high log rates when there are many filter clients. Perhaps we can open an issue to revert log level to trace in future?

I agree with that.
I think that in the future we could also strengthen the logic around metrics and keep the ability to debug any possible issues while keeping the log level back to trace.

@richard-ramos
Copy link
Member Author

Perhaps we can open an issue to revert log level to trace in future?

Issue: #1974

@richard-ramos richard-ramos merged commit e272bec into master Aug 30, 2023
12 of 13 checks passed
@richard-ramos richard-ramos deleted the chore/push branch August 30, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants