chore: add debug log indicating succesful message pushes and also log the message hash #1965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
one suggestion that was made during today's message reliability call was to add this information to help debug cases where a message appears to have been pushed succesfully to all subscribers yet the message appears to not have been delivered.
To see this change in action, it would require the fleet to be deployed and also use
debug
level for logsNotice that might add some noise on the logs for full filter nodes, due to changing the log level for one of the messages from TRACE to DEBUG, and also due to adding an extra log line, but it should be an acceptable tradeoff while dogfooding for filter is in progress. We can do a separate PR in the future to change the affected log lines to TRACE