Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Better feedback invalid content topic #2254

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR that gives better feedback when a wrong content topic is passed. In this case, the user will know better the expected format.

@Ivansete-status Ivansete-status marked this pull request as ready for review November 28, 2023 14:50
@Ivansete-status Ivansete-status self-assigned this Nov 28, 2023
Copy link

github-actions bot commented Nov 28, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2254

Built from 5ac4d13

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much!

@Ivansete-status Ivansete-status merged commit 72a1f8c into master Nov 30, 2023
9 of 10 checks passed
@Ivansete-status Ivansete-status deleted the better-feedback-invalid-content-topic branch November 30, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants