Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting connectivity loop interval to 15 seconds #2307

Merged

Conversation

gabrielmer
Copy link
Contributor

Description

After changing the connectivity loop interval from 15 seconds to 1 minute, the node is taking long to find peers at startup. Reverting the change and returning to 15 seconds intervals.

Changes

  • setting connectivity loop interval to 15 seconds

Issue

closes #2299

@gabrielmer gabrielmer self-assigned this Dec 19, 2023
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2307

Built from 2b61d62

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable. Lgtm!

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. indeed, every minute is to long, specially after startup.

in the future we may consider having a dynamic interval. the further to our target the shorter.

@gabrielmer gabrielmer merged commit a1b27ed into master Dec 20, 2023
9 of 10 checks passed
@gabrielmer gabrielmer deleted the fix-setting-connectivity-loop-interval-to-15-seconds branch December 20, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug/regression: Relay connection works no more
3 participants