fix: build failure on testwaku

[NagyZoltanPeter]

Description

test(peer-connection-managenent): Functional Tests (#2321) @ e9d083b introduced build error through ambigous function call, testwaku build failed on master.

It turned out, some commits ago a new - duplicated toBytes proc was introduced that makes build fail for testwaku.
Removed it and checked that all tests on master no runs fine.

Changes

• [X ] tests/testlib/sequtils.nim removed unnecessary toBytes

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2337

Built from 725784c

[Ivansete-status]

LGTM! Thanks for it!

[SionoiS]

Yes! Thanks I just notice the same thing.

[AlejandroCabeza]

Could somebody point me to the error, please?

[NagyZoltanPeter]

Could somebody point me to the error, please?

I just got ambiguous method call error while compiling testwaku. It is in the ci as well. Removing the toBytes has just simple solve the issue as that one is part of nim/stew already.

Forex:
"2024-01-05T13:49:49.2883483Z /home/runner/work/nwaku/nwaku/tests/waku_relay/test_message_id.nim(16, 7) template/generic instantiation of suite from here
2024-01-05T13:49:49.2886447Z /home/runner/work/nwaku/nwaku/tests/waku_relay/test_message_id.nim(17, 8) template/generic instantiation of test from here
2024-01-05T13:49:49.2891738Z /home/runner/work/nwaku/nwaku/tests/waku_relay/test_message_id.nim(18, 48) Error: ambiguous call; both byteutils.toBytes(s: string) [func declared in /home/runner/work/nwaku/nwaku/vendor/nim-stew/stew/byteutils.nim(246, 6)] and sequtils.toBytes(str: string) [proc declared in /home/runner/work/nwaku/nwaku/tests/testlib/sequtils.nim(4, 6)] match for: (string)
2024-01-05T13:49:49.2981179Z stack trace: (most recent call last)"
From https://pipelinesghubeus23.actions.githubusercontent.com/giLWQ9JLwXuGUVzynkfhnBAF1P5iNvXJvR07AsnDDAhJHignjF/_apis/pipelines/1/runs/15650/signedlogcontent/10?urlExpires=2024-01-08T15%3A10%3A47.6397526Z&urlSigningMethod=HMACV1&urlSignature=OllbNtIewZrVELlIYu0HS7yhyPdjIkM5uAGAKZUODNQ%3D
which is from: https://github.com/waku-org/nwaku/actions/runs/7422608920/job/20198270558#step:5:902

[gabrielmer]

Thank you! 🤩

[AlejandroCabeza]

Could somebody point me to the error, please?

I just got ambiguous method call error while compiling testwaku. It is in the ci as well. Removing the toBytes has just simple solve the issue as that one is part of nim/stew already.

Forex: "2024-01-05T13:49:49.2883483Z /home/runner/work/nwaku/nwaku/tests/waku_relay/test_message_id.nim(16, 7) template/generic instantiation of suite from here 2024-01-05T13:49:49.2886447Z /home/runner/work/nwaku/nwaku/tests/waku_relay/test_message_id.nim(17, 8) template/generic instantiation of test from here 2024-01-05T13:49:49.2891738Z /home/runner/work/nwaku/nwaku/tests/waku_relay/test_message_id.nim(18, 48) Error: ambiguous call; both byteutils.toBytes(s: string) [func declared in /home/runner/work/nwaku/nwaku/vendor/nim-stew/stew/byteutils.nim(246, 6)] and sequtils.toBytes(str: string) [proc declared in /home/runner/work/nwaku/nwaku/tests/testlib/sequtils.nim(4, 6)] match for: (string) 2024-01-05T13:49:49.2981179Z stack trace: (most recent call last)" From https://pipelinesghubeus23.actions.githubusercontent.com/giLWQ9JLwXuGUVzynkfhnBAF1P5iNvXJvR07AsnDDAhJHignjF/_apis/pipelines/1/runs/15650/signedlogcontent/10?urlExpires=2024-01-08T15%3A10%3A47.6397526Z&urlSigningMethod=HMACV1&urlSignature=OllbNtIewZrVELlIYu0HS7yhyPdjIkM5uAGAKZUODNQ%3D which is from: https://github.com/waku-org/nwaku/actions/runs/7422608920/job/20198270558#step:5:902

Oh, okay, I just tried running them and I got the issue. Funny how I didn't get that before.

LGTM :)