feat(networkmonitor): add support for rln #2401
Conversation
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
|
You can find the image built from this PR at Built from fb79f60 |
| defaultValue: true | ||
| name: "rln-relay" }: bool | ||
|
|
||
| rlnRelayCredIndex* {. |
There was a problem hiding this comment.
since network monitor will just monitor and not publish messages, maybe rlnRelayCredIndex can be removed?
There was a problem hiding this comment.
Yeah, makes sense, removed
| error "failed to mount waku metadata protocol: ", err=error | ||
| quit 1 | ||
|
|
||
| for pubsubTopic in conf.pubsubTopics: |
There was a problem hiding this comment.
in case you want to simplify the cli config just added this:
https://github.com/waku-org/nwaku/blob/master/apps/wakunode2/networks_config.nim#L20-L40
There was a problem hiding this comment.
Ok, I just imported the config from wakunode2 - I don't like it, but it's a reasonable start, if this gets moved to more general location, we can change this. But I felt like this is a better approach than to copy it to networkmonitor app
vpavlin
force-pushed
the
feat/networkmonitor-twn
branch
from
c29aee0
to
d8e699c
Compare
Description
This PR adds support of RLN into NetworkMonitor - so that we can tun it for The Waku Network
Changes
How to test
make networkmonitorcurl http://localhost:8008/metricsIssue
closes #2400