fix(wakunode2): move node config inside app init branch #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
fix-cluster-id-assignment
branch
from
52518c7
to
fce6826
Compare
Comment on lines
+106
to
+107
| info "Running nwaku node", version = app.git_version | ||
| logConfig(conf) |
There was a problem hiding this comment.
In general, it looks great to me this PR but does it do any harm having the version shown above?
There was a problem hiding this comment.
it doesn't but i don't think there is any merit in printing that log while running the keystore generator
|
You can find the image built from this PR at Built from b78f2f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the TWN default config into the wakunode2 default sub-command branch (i.e run the wakunode), instead of running it before the keystore generator subcommand
Changes
How to test
make -j16 wakunode2, run the keystore generatorIssue
closes #2422