Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updating TWN bootstrap fleet to waku.sandbox #2638

Merged
merged 5 commits into from
May 7, 2024
Merged

chore: updating TWN bootstrap fleet to waku.sandbox #2638

merged 5 commits into from
May 7, 2024

Conversation

gabrielmer
Copy link
Contributor

Description

Changing TWN bootstrap fleet to waku.sandbox which will be our stable "prod" fleet

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2638-rln-v1

Built from 53e2a6f

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2638-rln-v2

Built from 53e2a6f

@gabrielmer gabrielmer requested a review from jm-clius May 1, 2024 09:41
@gabrielmer gabrielmer marked this pull request as ready for review May 1, 2024 09:42
Ivansete-status
Ivansete-status approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 💯

@alrevuelta
Copy link
Contributor

Meta comment but if

"waku.sandbox which will be our stable "prod" fleet"

Perhaps that fleet should have a better name, eg waku.twn or waku.prod.

@gabrielmer
Copy link
Contributor Author

Meta comment but if

"waku.sandbox which will be our stable "prod" fleet"

Perhaps that fleet should have a better name, eg waku.twn or waku.prod.

Agreed! Not sure how the sandbox name was chosen but it doesn't describe much

@Ivansete-status
Copy link
Collaborator

Morning all!
@gabrielmer , @alrevuelta - re the fleet's name, we had some discussions and concluded that it was not correct to consider this fleet as some kind of "prod" fleet.

See:

and

@gabrielmer gabrielmer merged commit 22f64bb into master May 7, 2024
14 of 15 checks passed
@gabrielmer gabrielmer deleted the chore-updating-twn-bootstrap-fleet branch May 7, 2024 11:37
Ivansete-status pushed a commit that referenced this pull request May 14, 2024
@gabrielmer @Ivansete-status
chore: updating TWN bootstrap fleet to waku.sandbox (#2638)
8a95f7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@gabrielmer gabrielmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielmer @alrevuelta @Ivansete-status @jm-clius