Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rest/store/types: contentTopic -> content_topic #2646

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: rest/store/types: contentTopic -> content_topic #2646

merged 1 commit into from
Apr 29, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR to change to properly return content_topic in Store REST reponses

Issue

closes #2582

@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2646-rln-v1

Built from 164bea3

@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2646-rln-v2

Built from 164bea3

@Ivansete-status Ivansete-status marked this pull request as ready for review April 29, 2024 09:57
chaitanyaprem
chaitanyaprem reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to use constants for such field names which are common across all protocols to avoid such issues in the future.

gabrielmer
gabrielmer approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

SionoiS
SionoiS approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thank you for fixing the left-overs from Store v3 rebase.

@Ivansete-status
Copy link
Collaborator Author

Maybe better to use constants for such field names which are common across all protocols to avoid such issues in the future.

Thanks! I will consider for upcoming PRs

@Ivansete-status Ivansete-status merged commit 28389cf into master Apr 29, 2024
14 of 16 checks passed
@Ivansete-status Ivansete-status deleted the fix-content-topic branch April 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem left review comments

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS SionoiS approved these changes

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: contentTopic naming not consistent in the store response where is's content_topic
4 participants
@Ivansete-status @SionoiS @chaitanyaprem @gabrielmer