Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: closing ping streams #2692

Merged
merged 5 commits into from
May 13, 2024
Merged

chore: closing ping streams #2692

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ec4adf
adding logs
gabrielmer May 10, 2024
7a6ad69
improving logs
gabrielmer May 10, 2024
ad9b67a
deleting logs
gabrielmer May 10, 2024
115eccd
delete line
gabrielmer May 10, 2024
08df086
Merge branch 'master' into debug-investigating-open-ping-connections
gabrielmer May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions waku/node/waku_node.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,7 @@ proc keepaliveLoop(node: WakuNode, keepalive: chronos.Duration) {.async.} =
try:
let conn = await node.switch.dial(peer.peerId, peer.addrs, PingCodec)
let pingDelay = await node.libp2pPing.ping(conn)
await conn.close()
except CatchableError as exc:
waku_node_errors.inc(labelValues = ["keep_alive_failure"])

Expand Down
Loading