fix: more detailed logs to differentiate shards with peers #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 67c958b |
|
You can find the image built from this PR at Built from 67c958b |
Ivansete-status
approved these changes
Jun 9, 2024
gabrielmer
approved these changes
Jun 10, 2024
darshankabariya
added a commit
that referenced
this pull request
Jun 11, 2024
rymnc
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more information to the log, allowing users to differentiate shards and their connections.
Example :-
If shards match the peer, the previous log entry would be :- "reason = no shards in common"
Now it's look like this :- "reason = no shards in common: my_shards = [ x, y, z ] others_shards = [ a, b, c ]"
where the number within brackets represents the shard number.