Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updating nim-bearssl to release 0.2.3 #2796

Merged
merged 1 commit into from
Jun 10, 2024
Merged

chore: updating nim-bearssl to release 0.2.3 #2796

merged 1 commit into from
Jun 10, 2024

Conversation

gabrielmer
Copy link
Contributor

Description

When building wakunode2 some setups run into the following error

~/vendor/nim-bearssl/bearssl/rand.nim:35:34: error: passing argument 1 of ‘br_prng_seeder_system’ from incompatible pointer type [-Wincompatible-pointer-types]
   35 |   let seeder = prngSeederSystem(nil)

Updating nim-bearssl to include the following fix status-im/nim-bearssl@ff0b47e

Thanks @AlejandroCabeza for reporting!

Changes

  • updating nim-bearssl to release 0.2.3

Ivansete-status
Ivansete-status approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2796-rln-v1

Built from 5d6ac85

@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2796-rln-v2

Built from 5d6ac85

@gabrielmer gabrielmer merged commit dcff7e9 into master Jun 10, 2024
15 of 16 checks passed
@gabrielmer gabrielmer deleted the chore-updating-nim-bearssl branch June 10, 2024 16:07
darshankabariya pushed a commit that referenced this pull request Jun 11, 2024
@gabrielmer @darshankabariya
updating nim-bearssl to release 0.2.3 (#2796)
400ac68
rymnc pushed a commit that referenced this pull request Jun 20, 2024
@gabrielmer @rymnc
updating nim-bearssl to release 0.2.3 (#2796)
5eaa162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@AlejandroCabeza AlejandroCabeza AlejandroCabeza approved these changes

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

Assignees

@gabrielmer gabrielmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmer @AlejandroCabeza @Ivansete-status