Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add TWN parameters for RLNv2 #2843

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Jun 24, 2024

  • Add The Waku Network parameters for RLN v2.
  • Set epoch size in seconds.
  • Set amount of messages allowed per epoch.
  • Set new contract, present in Polygon zkEVM testnet.

@alrevuelta alrevuelta changed the title Add twn parameters Add TWN parameters for RLNv2 Jun 24, 2024
@alrevuelta alrevuelta changed the base branch from master to release/v0.30 June 24, 2024 14:09
Copy link

github-actions bot commented Jun 24, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2843

Built from 8e12f92

@alrevuelta alrevuelta changed the title Add TWN parameters for RLNv2 chore: add TWN parameters for RLNv2 Jun 24, 2024
@alrevuelta alrevuelta marked this pull request as ready for review June 27, 2024 08:41
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, but now that the epoch size is 600, can you add it in the array for the nullifierLog tests?

var testEpochSizes: seq[uint] = @[1,5,10,30,60]

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@alrevuelta
Copy link
Contributor Author

@rymnc Sure, done 3a28976

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if checks pass

@alrevuelta alrevuelta merged commit 7b97c80 into release/v0.30 Jun 27, 2024
9 of 10 checks passed
@alrevuelta alrevuelta deleted the add-twn-parameters branch June 27, 2024 09:45
Ivansete-status added a commit that referenced this pull request Jul 2, 2024
* CHANGELOG.md add info for v0.30.0
* fix(rln-relay): clear nullifier log only if length is over max epoch gap (#2836)
* chore: add TWN parameters for RLNv2 (#2843)
* fix(rln): nullifierlog vulnerability (#2855)
* chore(rln-relay): add chain-id flag to wakunode and restrict usage if mismatches rpc provider (#2858)

---------

Co-authored-by: Aaryamann Challani <[email protected]>
Co-authored-by: Alvaro Revuelta <[email protected]>
Ivansete-status added a commit that referenced this pull request Jul 2, 2024
chore: Update master from release v0.30 (#2866)

* CHANGELOG.md add info for v0.30.0
* fix(rln-relay): clear nullifier log only if length is over max epoch gap (#2836)
* chore: add TWN parameters for RLNv2 (#2843)
* fix(rln): nullifierlog vulnerability (#2855)
* chore(rln-relay): add chain-id flag to wakunode and restrict usage if mismatches rpc provider (#2858)
    
---------

Co-authored-by: Aaryamann Challani <[email protected]>
Co-authored-by: Alvaro Revuelta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants