-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add peer filtering by cluster for waku peer exchange #2932
Conversation
You can find the image built from this PR at
Built from 59edaf7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks greatt, thank you!
I think we should add a test case in the peer exchange suite, WDYT?
Also, in this PR too the linting check is failing, do you use nph version 0.5.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! Approving to not block it and happy to merge after Gabriel's comments are fixed :)
I'll add a test and check my nph version edit: I think switching to the new nim vscode extention has something to do with it. I'll try to fix my setup. |
Yes, that's the correct version! When I checkout to your branch I get the file formatted differently, so I think it's something in your setup |
Should be fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazingg, thanks so much!
Description
The peer pool in waku peer exchange no longer accept peers from other cluster.
Closes #2910