Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add peer filtering by cluster for waku peer exchange #2932

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jul 25, 2024

Description

The peer pool in waku peer exchange no longer accept peers from other cluster.

Closes #2910

@SionoiS SionoiS requested a review from a team July 25, 2024 19:29
@SionoiS SionoiS self-assigned this Jul 25, 2024
@SionoiS SionoiS changed the title fix: add peer filtering by cluster for waku peer exchange chore: add peer filtering by cluster for waku peer exchange Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2932

Built from 59edaf7

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks greatt, thank you!

I think we should add a test case in the peer exchange suite, WDYT?

Also, in this PR too the linting check is failing, do you use nph version 0.5.1?

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Approving to not block it and happy to merge after Gabriel's comments are fixed :)

waku/waku_peer_exchange/protocol.nim Outdated Show resolved Hide resolved
@SionoiS
Copy link
Contributor Author

SionoiS commented Jul 26, 2024

Looks greatt, thank you!

I think we should add a test case in the peer exchange suite, WDYT?

Also, in this PR too the linting check is failing, do you use nph version 0.5.1?

I'll add a test and check my nph version

edit: sionois@laptop:~/Github/nwaku$ nph --version v0.5.1-0-gde5cd48 is that not the correct version?

I think switching to the new nim vscode extention has something to do with it. I'll try to fix my setup.

@gabrielmer gabrielmer self-requested a review July 29, 2024 08:31
@gabrielmer
Copy link
Contributor

sionois@laptop:~/Github/nwaku$ nph --version v0.5.1-0-gde5cd48` is that not the correct version?

I think switching to the new nim vscode extention has something to do with it. I'll try to fix my setup.

Yes, that's the correct version! When I checkout to your branch I get the file formatted differently, so I think it's something in your setup

@SionoiS
Copy link
Contributor Author

SionoiS commented Jul 29, 2024

sionois@laptop:~/Github/nwaku$ nph --version v0.5.1-0-gde5cd48` is that not the correct version?
I think switching to the new nim vscode extention has something to do with it. I'll try to fix my setup.

Yes, that's the correct version! When I checkout to your branch I get the file formatted differently, so I think it's something in your setup

Should be fixed now!

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingg, thanks so much!

@SionoiS SionoiS merged commit b4618f9 into master Jul 29, 2024
9 of 11 checks passed
@SionoiS SionoiS deleted the fix--filter-peer-exchange-peers-by-cluster branch July 29, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: filter peers stored in cache by cluster-id in peer-exchange
3 participants