fix: network monitor improvements #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
changed the title
|
You can find the image built from this PR at Built from 2088b1c |
|
We're thinking alike :P -> #2930 |
Ivansete-status
approved these changes
Jul 29, 2024
| --rln-relay Enable spam protection through rln-relay: true|false [=true]. | ||
| --rln-relay-dynamic Enable waku-rln-relay with on-chain dynamic group management: true|false | ||
| [=true]. | ||
| --rln-relay-tree-path Path to the RLN merkle tree sled db (https://github.com/spacejam/sled). |
There was a problem hiding this comment.
qq: what is "sled" :) ?
There was a problem hiding this comment.
sled is a database used by RLN for storing the tree
| --rln-relay-eth-contract-address Address of membership contract on an Ethereum testnet. | ||
| --rln-relay-epoch-sec Epoch size in seconds used to rate limit RLN memberships. Default is 1 second. | ||
| [=1]. | ||
| --rln-relay-user-message-limit Set a user message limit for the rln membership registration. Must be a positive |
There was a problem hiding this comment.
Suggested change
| --rln-relay-user-message-limit Set a user message limit for the rln membership registration. Must be a positive | |
| --rln-relay-user-message-limit Set a user message limit (number of messages per epoch) for the rln membership registration. Must be a positive. |
| let totalNodes = flatNodes.len | ||
| let seenNodes = flatNodes.countIt(it.seen) | ||
| let totalNodes = discoveredNodes.len | ||
| #let seenNodes = totalNodes |
There was a problem hiding this comment.
Maybe we can directly remove that line
Suggested change
| #let seenNodes = totalNodes |
|
|
||
| info "discovered nodes: ", total = totalNodes, seen = seenNodes | ||
| info "discovered nodes: ", total = totalNodes #, seen = seenNodes |
There was a problem hiding this comment.
We can either remove that comment or uncomment it and uncomment the previous line
Suggested change
| info "discovered nodes: ", total = totalNodes #, seen = seenNodes | |
| info "discovered nodes: ", total = totalNodes |
| ports: | ||
| - '3000:3000' | ||
| volumes: | ||
| - grafana-data:/var/lib/grafana |
There was a problem hiding this comment.
I'm very curious about what the Grafana boards look like. For some reason, I miss the definition of the Grafana board itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wanted to run network monitor to get an idea of status network with clusterID 16 especially to debug peer discovery and connectivity.
Noticed that peer filtering was not happening and it was trying to connect to all peers even from TWN and made changes.
Changes