chore: libwaku retrieve my enr and adapt golang example #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 2333ec7 |
Ivansete-status
requested review from
richard-ramos,
darshankabariya,
gabrielmer and
NagyZoltanPeter
NagyZoltanPeter
approved these changes
Aug 21, 2024
examples/golang/waku.go
Outdated
| C.cGoWakuGetMyENR(self.ctx, resp) | ||
|
|
||
| if C.getRet(resp) == C.RET_OK { | ||
| var listenAddresses = C.GoStringN(C.getMyCharPtr(resp), C.int(C.getMyCharLen(resp))) |
There was a problem hiding this comment.
Maybe a bit misleading to call it listenAddresses and not the ENR.
I remember that is different also in /debug/info API result.
gabrielmer
approved these changes
Aug 21, 2024
examples/golang/waku.go
Outdated
Comment on lines
460
to
461
| var listenAddresses = C.GoStringN(C.getMyCharPtr(resp), C.int(C.getMyCharLen(resp))) | ||
| return listenAddresses, nil |
There was a problem hiding this comment.
Shouldn't we change the variable name to enr or something like that? looks like we kept the same variable name after copy-pasting from WakuListenAddresses()
There was a problem hiding this comment.
ooh @NagyZoltanPeter added the same comment a few minutes before I did lol. Nice!
There was a problem hiding this comment.
Thank you so much guys ! I'll change that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new "get ENR" method available in libwaku
Changes
waku_get_my_enravailable inlibwakuwaku_get_my_enrfunction