Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating upload and download artifact actions to v4 #3047

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Sep 20, 2024

Description

Updating upload and download artifact actions to v4 as versions used by us fail because they're deprecated

Copy link

github-actions bot commented Sep 20, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3047

Built from 3f42327

@gabrielmer gabrielmer changed the title chore: updating upload artifact workflow to v4.4.0 chore: updating upload and download artifact workflow to v4 Sep 20, 2024
@gabrielmer gabrielmer changed the title chore: updating upload and download artifact workflow to v4 chore: updating upload and download artifact actions to v4 Sep 20, 2024
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!! Thank you!

@gabrielmer gabrielmer merged commit 7c4a971 into master Sep 24, 2024
16 of 17 checks passed
@gabrielmer gabrielmer deleted the fix-updating-upload-artifact-workflow-version branch September 24, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants