chore: Enhancement on building nph and made it available naturaly on the path #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h as being copied next to nim.
NagyZoltanPeter
requested review from
richard-ramos,
darshankabariya,
gabrielmer and
Ivansete-status
|
You can find the image built from this PR at Built from 4bdd2c4 |
richard-ramos
approved these changes
Oct 28, 2024
Ivansete-status
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due that vscode nph extension is taking nph binary from the path, to avoid possible discrepancies - maybe of having other nph version avail from somewhere else - this chore aims to build nph binary only if needed and move it next to nim binary - into vendor/nimbus-build-system/vendor/Nim/bin/ directory, which is inherently added to the path with the .env.sh script.
Changes
Only Makefile changes