fix(auto_update): use correct argument order

wakurobotics · Feb 7, 2024 · 7e697db · 7e697db
1 parent efa4c25
commit 7e697db
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/supervisor/autoupdate.go b/supervisor/autoupdate.go
@@ -89,17 +89,17 @@ func (s *Supervisor) update() error {
 		return err
 	}
 
-	log := logrus.WithFields(logrus.Fields{
-		"current": currentVersion,
-		"latest":  m.Version,
-	})
-
 	manifestVersion, err := m.parseVersion()
 	if err != nil {
 		return fmt.Errorf("failed to parse manifest Version: %s: %+v", m.Version, err)
 	}
 
-	if compareSemver(manifestVersion, currentVersion) < 1 {
+	log := logrus.WithFields(logrus.Fields{
+		"current": currentVersion,
+		"latest":  manifestVersion,
+	})
+
+	if compareSemver(currentVersion, manifestVersion) < 1 {
 		// version greater or equal; nothing to do
 		log.Info("current version greater or equal; nothing to do")
 		return nil

diff --git a/supervisor/semver_test.go b/supervisor/semver_test.go
@@ -13,7 +13,7 @@ func TestSupervisor_compareSemver(t *testing.T) {
 	res = compareSemver([]int{1, 0, 0}, []int{1, 1, 0})
 	assert.Equal(t, 1, res)
 
-	res = compareSemver([]int{1, 0, 0}, []int{1, 0, 1})
+	res = compareSemver([]int{1, 0, 0}, []int{1, 0, 2})
 	assert.Equal(t, 1, res)
 
 	res = compareSemver([]int{1, 0, 0}, []int{1, 1, 1})