Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws sdk to 1.34.3 #22

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Update aws sdk to 1.34.3 #22

merged 1 commit into from
Aug 12, 2020

Conversation

bunsenmcdubbs
Copy link

Update to https://github.com/aws/aws-sdk-go/releases/tag/v1.34.3 which contains aws/aws-sdk-go#3476 , a fix for aws/aws-sdk-go#3406 which we believe is a root cause of wal-g/wal-g#656

bhmayer
bhmayer approved these changes Aug 12, 2020
View reviewed changes
Copy link

@bhmayer bhmayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Excited for sdk change for retries on "use of closed network connection" errors

@bunsenmcdubbs bunsenmcdubbs merged commit 629232a into wal-g:master Aug 12, 2020
@bunsenmcdubbs bunsenmcdubbs deleted the update-aws-sdk-1.34.3 branch August 12, 2020 20:53
@bunsenmcdubbs bunsenmcdubbs mentioned this pull request Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhmayer bhmayer bhmayer approved these changes

@jschaf jschaf jschaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bunsenmcdubbs @jschaf @bhmayer