Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks strings as mutable in preparation for Ruby freezing strings #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

radville
Copy link

There was a deprecation warning for chilled strings merged recently in Ruby: ruby/ruby@12be40a

And with that we started to see the following warning coming from org-ruby:

vendor/gems/3.4.0/ruby/3.4.0+0/gems/org-ruby-0.9.12/lib/org-ruby/html_output_buffer.rb:85: warning: literal string will be frozen in the future

This makes updates to freeze strings by default and mark others unfrozen where needed in order to maintain functionality with smallest changes possible.

@radville radville marked this pull request as ready for review August 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant