Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Limitations" section to the readme to properly address eslint bug #44

Merged
merged 1 commit into from
Dec 23, 2015

Conversation

baer
Copy link
Contributor

@baer baer commented Dec 23, 2015

Explain #43 right in the README.

@exogen @ryan-roemer

@@ -86,6 +86,10 @@ ESLint configuration is broken apart in `./rules` containing ESLint's rules and
"phantom": true
```

## Limitations

Due to an issue with ESLint, config extension cannot be called from a globally installed (`npm install -g eslint`) eslint. It can however be run properly using eslint installed directly to your package's `node_modules`. This can be done by either calling it directly (`./node_modules/.bin/eslint .`) or from within an npm script since they automatically check local `node_modules` first. This will be tracked in issue #43.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to 43.

Also possibly add

export PATH="./node_modules/.bin:${PATH}"

as a documented option to "use local first"? (Some shell curmudgeons won't like that recommendation though 😉 )

baer added a commit that referenced this pull request Dec 23, 2015
…ude-limitations

Add "Limitations" section to the readme to properly address eslint bug
@baer baer merged commit 430ec98 into master Dec 23, 2015
@baer baer deleted the feature/update-readme-to-include-limitations branch December 23, 2015 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants