Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabindex support, bower.json, refactor scroll-to-center #20

Merged
merged 8 commits into from
May 4, 2017

Conversation

z4y4ts
Copy link
Contributor

@z4y4ts z4y4ts commented Apr 21, 2017

Hi!

I'd like to contribute few features we've implemented for our project Video XBlock

  1. Add bower.json to make your plugin installable with Bower.
  2. Move scroll-to-center code to src.
  3. Add tabindex option. It's essential for a11y support. I.e. makes transcripts navigable via keyboard only.
  4. Bump version to 0.8.1

Looking forward to hearing from you.

dorosh and others added 8 commits December 15, 2016 15:50
add repo into bower store
Add into options 'tabindex' for manage tabindex transcript lines
* Feature/scroll to center (#1)

* Auto scroll to the center of transcripts block.

* Fix bower.json syntax.
@z4y4ts z4y4ts changed the title Few changes Add tabindex support, bower.json, refactor scroll-to-center Apr 21, 2017
@z4y4ts
Copy link
Contributor Author

z4y4ts commented May 4, 2017

Hi @walsh9,

I hope you're doing well.

Any change this PR can be merged? How can I help you with this?

Best regards,
Alexander

@walsh9
Copy link
Owner

walsh9 commented May 4, 2017

Hey, thanks for the reminder. This looks good. Thanks!

@walsh9 walsh9 merged commit 3b9b2cf into walsh9:master May 4, 2017
@z4y4ts
Copy link
Contributor Author

z4y4ts commented May 4, 2017

Hey, thanks for merging! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants