hotfix: set wallet credential format column default value #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeplotean
force-pushed
the
fix/wallet-credential-format-default-value
branch
from
7fe2cbf
to
966419c
Compare
mikeplotean
force-pushed
the
fix/wallet-credential-format-default-value
branch
from
966419c
to
e4f688e
Compare
|
waltkb
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When kotlin-exposed attempts to add the missing table / columns (format column for wallet-credentials table), it fails for tables that already have records.
This hotfix sets the wallet-credential format column to have a default value -
CredentialFormat.jwt_vc_json.Since the wallet-api couldn't claim until now other credential types than jwt and sdjwt, this solution is safe (both being covered by the aforementioned format). But a proper solution would be introducing a db migration strategy.