Fixes leaking fds created by 'pipe()' call #2745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `lws_pt_destroy()` logic to ensure the pipe fds are closed if either `pt->dummy_pipe_fds[0]` or `pt->dummy_pipe_fds[1]` are still valid (previously was only checking `pt->dummy_pipe_fds[0]` which was resulting in the write fd to leak whenever a context was destroyed).
|
@lws-team Just as an FYI, I discovered this while building off |
lws-team
force-pushed
the
main
branch
2 times, most recently
from
07b1c27
to
a99b954
Compare
|
Thanks forthe patch and sorry for the delay. It's pushed on main + v4.3-stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
lws_pt_destroy()logic to ensure the pipe fds are closed if eitherpt->dummy_pipe_fds[0]orpt->dummy_pipe_fds[1]are still valid (previously was only checkingpt->dummy_pipe_fds[0]which was resulting in the write fd to leak whenever a context was destroyed).Potential fix for issue: #2744