Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FsZip: checklist #392

Open
18 of 24 tasks
warpdesign opened this issue Feb 21, 2023 · 1 comment
Open
18 of 24 tasks

FsZip: checklist #392

warpdesign opened this issue Feb 21, 2023 · 1 comment

Comments

@warpdesign
Copy link
Owner

warpdesign commented Feb 21, 2023

Checklist to have a MVP of a (readonly) zip plugin:

  • correctly handle goto parent when at the root of the zip (should change FS)
  • correctly handle directories inside a zip file when typing a path, eg. /tmp/archive.zip/foo/
  • correctly handle directories inside a zip file when double-clicking on a directory inside an opened archive
  • need to allow browsing a zip by double-clicking it
  • need to add readonly + checks on Fs so that read+delete+paste+rename operations are disabled
  • Error handling: archive.zip/foo-does-not-exist
  • Error handling: archive.zip/foo-exist-but-is-a-file
  • close zip file when closing cache or browsing out of zip
  • need to handle opening a file from zip (by extracting the file in /tmp)
  • fix: archive.zip/foo/bar/ appears empty
  • Error: opening an invalid zip will keep FsZip ref, so opening a valid zip will fail since it will attempt to open previous file
  • Error handling: bad archive
  • Error handling: no read access to archive
  • need to handle copying files from zip
  • need to handle copying folders from zip
  • open in terminal should do nothing if fs.options.indirect is true
  • should not attempt to open zip file if foo.zip is a directory
  • should disable some context menu entries when readonly is true
  • check that everything relying on directory separator works as expected on Windows
  • error message is correct when attempting to enter a path to a non-supported file, see Improve error message #409
  • should show an error message when attempting to open a password protected zip (not sure the zip library supports it)
  • /foo/archive.zip is a directory
  • /foo/archive.zip/bar/archive2.zip: should openFile
  • /foo/archive.zip/bar/archive2.zip is a directory (should browse it)
@warpdesign
Copy link
Owner Author

Experiment with archive-files: it seems to support a wide range of archives and has stream support.

  • list entries (per dir or all entries?)
  • test stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant