Add zip browsing #394
Open
Add zip browsing #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warpdesign
force-pushed
the
add-zip-browsing
branch
from
7f1da2a
to
7edb083
Compare
warpdesign
force-pushed
the
add-zip-browsing
branch
4 times, most recently
from
728221d
to
7044bd3
Compare
Note: shows a very simple zip only. Lots of work needed: - need to add readonly + checks on Fs so that read+delete+paste+rename operations are disabled - need to allow browsing into a dir inside the zip - need to allow browsing a zip by double-clicking in it - need to handle opening a file from zip (by extracking the file in /tmp) - need to handle copying files from zip
Also added new icons: - Icon inside toolbar input that shows current FS's icon - Lock icon when filesystem is readonly
This is needed since we may switch to different Fs in the middle of a path.
Also fixed FileDescriptor.name which was containing full file path.
Some zip have a specific entry for directories inside the archive: 'foo/' but some zips don't have it, so we have a manually add 'foo/' if the archive contains for example 'foo/bar'. Also added new 'indirect' option on Fs that will be used when opening a file needs first to uncompress (eg. zip archive) or transfer (eg. FTP) file before it can be opened by the OS. Last but not least, onFsChange was made optional since archive Fs don't have it (at least not in the initial version).
When entering a zip subdirectory, the FileDescriptor's dir was missing the current directory relative to the zip.
Also: cleaned-up write-only methods (these should be optionals)
This PR fixes two things: - when copying files from a zip directory, closing the zip tab, then pasting the files in another tab, the cache's zip file was closed, so we re-open it. - FsZip file listing had a bug where a directory partially matching another directory would return non-existing folders, for eg. `/foo` & `/foo.bar`.
Also simplified paste enable checks: ignore file under mouse for now since we paste on current cache & not on the folder under the mouse anyway.
warpdesign
force-pushed
the
add-zip-browsing
branch
from
7044bd3
to
166bf17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP checklist: #392