Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Pre Launch Cleanup #86

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Additional Pre Launch Cleanup #86

merged 2 commits into from
Oct 1, 2019

Conversation

torch2424
Copy link

@torch2424 torch2424 commented Oct 1, 2019 •
edited
Loading

relates to #83

This cleans up some more of the docs, and fixes some bugs I came across when testing this in a minimal rollup/browser and node environment 😄

  • Fixed bug where copy/pasting some examples didn't work out of the box. (Top Level await)
  • Fixed WASI index.esm.js having a use of global. Fixed this by moving the cjs builds to the end. of the build order
  • More general docs improvements

@torch2424 torch2424 added the bug Something isn't working label Oct 1, 2019
@torch2424 torch2424 self-assigned this Oct 1, 2019
@torch2424 torch2424 merged commit a269529 into master Oct 1, 2019
@torch2424 torch2424 deleted the pre-launch-fixes branch October 1, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees

@torch2424 torch2424

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torch2424 @syrusakbary