Fix Threads/Imports Tests

[ptitSeb]

Describe the bug

On the feat_sharedmemory branch, the wast test threads/imports is failling.
The faillure is:

Error: Failed directives on tests/wast/spec/proposals/threads/imports.wast:
  • assert_invalid: expected "multiple tables", got "instantiation failed with: constant expression required" (309:1)
  • assert_invalid: expected "multiple tables", got "instantiation failed with: constant expression required" (313:1)
  • expected module to fail to build (317:1)
  • instantiation failed with: Error while importing "spectest"."shared_memory": unknown import. Expected Memory(MemoryType { minimum: 1 pages, maximum: Some(2 pages), shared: true }) (499:1)
  • assert_unlinkable: expected incompatible import type, got instantiation failed with: Error while importing "spectest"."shared_memory": unknown import. Expected Memory(MemoryType { minimum: 1 pages, maximum: Some(2 pages), shared: false }) (501:1)

Technically, the sub-tests are failling as expected, but the error message is a generic one instead of a specific one.

[syrusakbary]

For the error:

  • instantiation failed with: Error while importing "spectest"."shared_memory": unknown import. Expected Memory(MemoryType { minimum: 1 pages, maximum: Some(2 pages), shared: true }) (499:1)

It seems we need to add a new shared_memory in the spectest runner:

https://github.com/wasmerio/wasmer/blob/master/tests/lib/wast/src/spectest.rs#L32-L46

So the linked code becomes:

    let shared_memory = ...
    imports! {
        "spectest" => {
            "print" => print,
            "print_i32" => print_i32,
            "print_i64" => print_i64,
            "print_f32" => print_f32,
            "print_f64" => print_f64,
            "print_i32_f32" => print_i32_f32,
            "print_f64_f64" => print_f64_f64,
            "global_i32" => global_i32,
            "global_i64" => global_i64,
            "global_f32" => global_f32,
            "global_f64" => global_f64,
            "table" => table,
            "memory" => memory,
            "shared_memory" => shared_memory,
        },
    }

[ptitSeb]

Merged