Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Disabled create-exe Integration Tests #3615

Closed
theduke opened this issue Feb 23, 2023 · 1 comment
Closed

Fix Disabled create-exe Integration Tests #3615

theduke opened this issue Feb 23, 2023 · 1 comment
Assignees
@ptitSeb
Labels
priority-medium Medium priority issue 🧪 tests I love tests
Milestone
v3.2

Comments

@theduke
Copy link
Contributor

theduke commented Feb 23, 2023 •
edited
Loading

During the merge of #3422 some of the create-exe tests were disabled.

We need to determine the cause , fix it and re-enable the tests.

Disabled tests:

  • create_exe_works_multi_command_args_handling
  • test_cross_compile_python_windows
  • create_exe_with_object_input_serialized
  • create_exe_serialized_works

@ptitSeb
@theduke theduke added the 🧪 tests I love tests label Feb 23, 2023
@theduke theduke added this to the v3.2 milestone Feb 23, 2023
@theduke theduke changed the title Fix the test_cross_compile_python_windows Integration Test Fix the create-exe Integration Tests Feb 23, 2023
theduke added a commit that referenced this issue Feb 23, 2023
@theduke
HACK: Disable 3 create-exe integration tests
b9c7b81 
Just for the WASIX merge.

Must be fixed and re-enabled.

See #3615
@theduke theduke mentioned this issue Feb 23, 2023
Merged
@theduke theduke changed the title Fix the create-exe Integration Tests Fix Disabled create-exe Integration Tests Feb 23, 2023
@theduke theduke mentioned this issue Feb 23, 2023
Closed
@ptitSeb ptitSeb self-assigned this Feb 28, 2023
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Feb 28, 2023
@ptitSeb ptitSeb mentioned this issue Mar 1, 2023
Merged
@ptitSeb
Copy link
Contributor

ptitSeb commented Mar 2, 2023

Fixed with #3636

@ptitSeb ptitSeb closed this as completed Mar 2, 2023
@Michael-F-Bryan Michael-F-Bryan mentioned this issue Oct 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptitSeb ptitSeb

Labels
priority-medium Medium priority issue 🧪 tests I love tests
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
2 participants
@theduke @ptitSeb