Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new SIMD instructions in compiler LLVM #2306

Merged
merged 8 commits into from
May 13, 2021
Merged

Implement new SIMD instructions in compiler LLVM #2306

merged 8 commits into from
May 13, 2021

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented May 11, 2021 •
edited
Loading

Recreating as I can't reopen #2302

Review

  • Add a short description of the change to the CHANGELOG.md file

@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review May 11, 2021 21:40
Fix bug in I32x4TruncSatF64x2SZero
88d2ac9 
We need to use LEF64, not LEF32, when dealing with f64s
nlewycky
nlewycky approved these changes May 11, 2021
View reviewed changes
lib/compiler-llvm/src/translator/code.rs Outdated Show resolved Hide resolved
lib/compiler-llvm/src/translator/code.rs Outdated Show resolved Hide resolved
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 12, 2021
@bors
Try #2306:
7c41a87
@bors
Copy link
Contributor

bors bot commented May 12, 2021

try

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 13, 2021
@bors
Try #2306:
9dff355
@bors
Copy link
Contributor

bors bot commented May 13, 2021

try

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 13, 2021

Build succeeded:

@bors bors bot merged commit d3e2ba3 into master May 13, 2021
@bors bors bot deleted the feature/update-wasm-simd branch May 13, 2021 18:25
This was referenced May 15, 2021
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewycky nlewycky nlewycky approved these changes

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @nlewycky