Fix Windows crash on caching compiled artifact. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory clone function wasn't able to write to new reserved memory object. Changed so allocating Memory objects with protection flag allocates commited memory.
repi
force-pushed
the
windows-memory-clone-crash
branch
from
abbbe77
to
36a78a2
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 8, 2019
428: Fix Windows crash on caching compiled artifact. r=syrusakbary a=repi Memory clone function wasn't able to write to new reserved memory object. Changed so allocating Memory objects with protection flag allocates commited memory. And added unit test to verify that it doedsn't crash anymore. Not fully sure this is the best solution though, but fixes this specific clone crash. Co-authored-by: Johan Andersson <[email protected]>
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory clone function wasn't able to write to new reserved memory object.
Changed so allocating Memory objects with protection flag allocates commited memory. And added unit test to verify that it doedsn't crash anymore.
Not fully sure this is the best solution though, but fixes this specific clone crash.