Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SdkGenerator/Server/EmailSenderG.hs -> genNewEmailSenderApi -> remove new from name? #1706

Open
Martinsos opened this issue Jan 31, 2024 · 1 comment
Labels

Comments

@Martinsos
Copy link
Member

Martinsos commented Jan 31, 2024

Following up on this comment #1701 (comment) .

Actually this is not the only SDK generator function that has new in the name, I just realized @infomiho added new prefix to most of those that he refactored -> @infomiho was the idea to remove this later?

@infomiho
Copy link
Contributor

infomiho commented Feb 6, 2024

I agree that we should remove it 👍

It was a transient name that helped me to differentiate the old from the new stuff. We agreed we'll refactor the exports anyways, so could handle this then as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants