Implement new wasp/server/email API #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
commented
Jan 30, 2024
| @@ -8,7 +8,7 @@ import type { | |||
| {=# isAuthEnabled =} | |||
| import { throwInvalidCredentialsError } from 'wasp/auth/utils' | |||
| {=/ isAuthEnabled =} | |||
| import type { GetAllQuery, GetQuery, CreateAction, UpdateAction, DeleteAction } from "{= crudTypesImportPath =}"; | |||
| import type { {= crud.name =} } from "wasp/server/crud"; | |||
There was a problem hiding this comment.
Fixing the CRUD bug in new-sdk branch (should be resolved after we merge the wasp/client/crud API changes)
Martinsos
reviewed
Jan 30, 2024
| {=! Used by our code, uncodumented (but accessible) for users. =} | ||
| "./email/core/types": "./dist/email/core/types.js", | ||
| "./server/email/core/types": "./dist/server/email/core/types.js", |
There was a problem hiding this comment.
If you know we still need these, it is maybe best if you move it below to section "still needed, reconsider during refactoring."? No need to do it now, just idea for future PRs.
Martinsos
reviewed
Jan 30, 2024
| @@ -17,8 +17,8 @@ import qualified Wasp.Generator.SdkGenerator.Common as C | |||
| import qualified Wasp.Generator.SdkGenerator.EmailSender.Providers as Providers | |||
| import Wasp.Util ((<++>)) | |||
|
|
|||
| genEmailSender :: AppSpec -> Generator [FileDraft] | |||
| genEmailSender spec = case maybeEmailSender of | |||
| genNewEmailSenderApi :: AppSpec -> Generator [FileDraft] | |||
Martinsos
approved these changes
Jan 30, 2024
Martinsos
force-pushed
the
new-sdk-server-email
branch
from
274b650
to
5213506
Compare
sodic
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the whole
sdk/emailfolder tosdk/server/email.