Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of wasp errors and warnings during wasp start (especialy prisma migrate) #2326

Open
Martinsos opened this issue Oct 8, 2024 · 0 comments
Labels
dx shouldfix We should do/fix this at some point

Comments

@Martinsos
Copy link
Member

Martinsos commented Oct 8, 2024

Here is a good example of an error I had:

image

I didn't turn on the database. There was an error about it at the top, but even though it errored, there was Database successfully set up and it continued! It should have failed there and then, or at least not say database was successfully set up.

Then, all these Prisma errors were prtined, from building SDK. For some reason, no ! in [ Wasp ] which indicates it is an error (from stderr). Not sure if those are really coming to stdout, or if we somehow forgot to acknolwedge it is coming from stderr, we should look into it.
These got all my attention.

Then, tehre was prisma db-migrate-dev warning at the bottom -> I completely missed that one, it is so dark and unimposing next to the red and white that I didn't see it at all. It should be much harder to miss, some stronger color, something bright.

Except for small issues that I listed here, that we should probably fix individually one by one, I would love if we possibly had some way to collect all the errors and then print them at the end at one place: there was error with db, there is warning for prisma, there was error with SDK. We can tell them to go look it up, maybe we don't have to show all of it, but some kind of summary of everything taht is failing / warning could be great.

Another thing we could do is just make sure that errors stand out more. Reduce the noise in general, have standard way for showing all errors that is quite clear about what you should look at and hard to miss, and then also making sure we don't print too much noise, because then you start disregarding information.

Related issues:

@Martinsos Martinsos added dx shouldfix We should do/fix this at some point labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx shouldfix We should do/fix this at some point
Projects
None yet
Development

No branches or pull requests

1 participant